Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and Fix Profiler #12940

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Update and Fix Profiler #12940

merged 5 commits into from
Dec 16, 2024

Conversation

matekelemen
Copy link
Contributor

Changelog

  • fix symbol exports on windows
    • Profiler is a template with explicit instantiations but its function definitions are split between implementation headers and sources, which requires extra attention when exporting.
  • prevent profilers with different time units of overwriting each others' output files
    • Profilers with different time units wrote their output when destroyed to the same file (kratos_profiler_output.json). Now the name includes the time unit to prevent this (e.g.: kratos_profiler_output_us.json).
  • fix minimum call durations
    • profiled scopes keep track of minimum and maximum durations, but the minimum was broken due to buggy initialization.

@matekelemen matekelemen marked this pull request as ready for review December 15, 2024 15:01
@matekelemen matekelemen requested a review from a team as a code owner December 15, 2024 15:01
@matekelemen matekelemen merged commit 06eeea3 into master Dec 16, 2024
11 checks passed
@matekelemen matekelemen deleted the core/profiler branch December 16, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants